Change in osmo-bsc[master]: codec_pref: check codec configuration before start

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Oct 6 10:20:05 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11243 )

Change subject: codec_pref: check codec configuration before start
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/11243/1/src/osmo-bsc/osmo_bsc_main.c
File src/osmo-bsc/osmo_bsc_main.c:

https://gerrit.osmocom.org/#/c/11243/1/src/osmo-bsc/osmo_bsc_main.c@885
PS1, Line 885: 	rc = check_codec_pref(&bsc_gsmnet->bsc_data->mscs);
I think it's not only sufficient to do this here.  It should also be verified whenever any of the related input data changes, i.e. if the MSC codec preferences are changed, or if the BTS related settings change.  However, we then run into a bit of a chicken-and-egg situation on initial startup.  So those checks should be executed on any VTY change at runtime, but not during initial config file parse, as at that time not both BTS and MSC settings are already present.

This cold be a follow-up patch.



-- 
To view, visit https://gerrit.osmocom.org/11243
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice827896bab1a2330741e0fccc731a04f1a07d38
Gerrit-Change-Number: 11243
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Comment-Date: Sat, 06 Oct 2018 10:20:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181006/ef19d618/attachment.htm>


More information about the gerrit-log mailing list