This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11232 ) Change subject: store gsup peer upon accepting LU ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/11232/2/src/hlr.c File src/hlr.c: https://gerrit.osmocom.org/#/c/11232/2/src/hlr.c@307 PS2, Line 307: luop->peer here you are assuming that it will always be printable ASCII. That's true for the moment but not really future compatible, when arbitrary binary blobs could be used e.g. to represent [encoded] global titles. I would at least add a FIXME around that. A more "proper" solution would probably check for non-printable characters and do a hexdump if such are found. -- To view, visit https://gerrit.osmocom.org/11232 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If438664faa5d68404f465f8b2002c6d03bbf3ceb Gerrit-Change-Number: 11232 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Comment-Date: Fri, 05 Oct 2018 07:54:18 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181005/d0a7bf9b/attachment.htm>