Change in osmo-ttcn3-hacks[master]: BTS_Tests.ttcn: fix: properly detect Measurement Reports

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Oct 4 16:34:06 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11224 )

Change subject: BTS_Tests.ttcn: fix: properly detect Measurement Reports
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/11224/2/bts/BTS_Tests.ttcn
File bts/BTS_Tests.ttcn:

https://gerrit.osmocom.org/#/c/11224/2/bts/BTS_Tests.ttcn@3762
PS2, Line 3762: 	[exp_sacch] as_meas_res(verify_meas := false);
I think you are changing logic here too, because if  exp_sacch=false you want to fail if you receive something there, but you don't do that after your change.

BTW: Does TTCN3 supports passing params by name instead of order?



-- 
To view, visit https://gerrit.osmocom.org/11224
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea5ee868ede8bfe1e2b1cbf5abcbf2844d3fe9a4
Gerrit-Change-Number: 11224
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Oct 2018 16:34:06 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181004/3df93dd7/attachment.htm>


More information about the gerrit-log mailing list