This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11220 Change subject: osmo-bsc: Add default case for switch(enum) ...................................................................... osmo-bsc: Add default case for switch(enum) After commit https://gerrit.osmocom.org/#/c/libosmo-abis/+/11207/ (Iaa33b793f89f2d16c9d949503c5ecc195bbcd2a4), input_signal_data->link_type exposes proper enum type, and compiler can warn about missing cases: osmo-bsc/bts_ericsson_rbs2000.c: In function ‘inp_sig_cb’: osmo-bsc/bts_ericsson_rbs2000.c:124:3: error: enumeration value ‘E1INP_SIGN_NONE’ not handled in switch [-Werror=switch] switch (isd->link_type) { ^~~~~~ Change-Id: Ia407a5072896377b68e914e2a05b5e01292ee8ee --- M src/osmo-bsc/bts_ericsson_rbs2000.c M src/osmo-bsc/bts_nokia_site.c M src/osmo-bsc/bts_siemens_bs11.c 3 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/20/11220/1 diff --git a/src/osmo-bsc/bts_ericsson_rbs2000.c b/src/osmo-bsc/bts_ericsson_rbs2000.c index ed3db93..4d1e91b 100644 --- a/src/osmo-bsc/bts_ericsson_rbs2000.c +++ b/src/osmo-bsc/bts_ericsson_rbs2000.c @@ -130,6 +130,8 @@ else bootstrap_om_trx(isd->trx); break; + default: + break; } break; case S_L_INP_TEI_DN: diff --git a/src/osmo-bsc/bts_nokia_site.c b/src/osmo-bsc/bts_nokia_site.c index 052741e..66972c2 100644 --- a/src/osmo-bsc/bts_nokia_site.c +++ b/src/osmo-bsc/bts_nokia_site.c @@ -168,6 +168,8 @@ else bootstrap_om_trx(isd->trx); break; + default: + break; } break; case S_L_INP_TEI_UNKNOWN: diff --git a/src/osmo-bsc/bts_siemens_bs11.c b/src/osmo-bsc/bts_siemens_bs11.c index 78a87e5..2cb676c 100644 --- a/src/osmo-bsc/bts_siemens_bs11.c +++ b/src/osmo-bsc/bts_siemens_bs11.c @@ -579,6 +579,8 @@ if (isd->trx->bts->type == GSM_BTS_TYPE_BS11) bootstrap_om_bs11(isd->trx->bts); break; + default: + break; } } -- To view, visit https://gerrit.osmocom.org/11220 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia407a5072896377b68e914e2a05b5e01292ee8ee Gerrit-Change-Number: 11220 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181003/085ec711/attachment.htm>