Change in osmo-ttcn3-hacks[master]: BTS_Tests.ttcn: fix: properly expect I-frames in f_TC_encr_cmd()

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11204 )

Change subject: BTS_Tests.ttcn: fix: properly expect I-frames in f_TC_encr_cmd()
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/11204/1/bts/BTS_Tests.ttcn
File bts/BTS_Tests.ttcn:

https://gerrit.osmocom.org/#/c/11204/1/bts/BTS_Tests.ttcn@3753
PS1, Line 3753: 	RslLinkId link_id,
> Hmm, this format is used at least for SS/USSD related templates ;) […]
I'd personally stick to regular "fit everything as much as possible into one line" format, that's what I'm used to (and I guess most people too) when looking at functions.


https://gerrit.osmocom.org/#/c/11204/1/bts/BTS_Tests.ttcn@3769
PS1, Line 3769: 	[] RSL.receive { repeat; }
> What if I do this in a separate change for both f_unitdata_mo and f_data_mo?
Sure, np.



-- 
To view, visit https://gerrit.osmocom.org/11204
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08cb28dd9fa23f3ef8b0c9ede3d4c47f5702a1c1
Gerrit-Change-Number: 11204
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Wed, 03 Oct 2018 09:39:32 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181003/6371f7a0/attachment.htm>