This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11180 ) Change subject: firmware/layer1: inform about unhandled scheduler tasks ...................................................................... firmware/layer1: inform about unhandled scheduler tasks The mframe_task2chan_nr() is used to get the channel number (encoded according to 08.58 Chapter 9.3.1) corresponding to a given multi-frame task type. It makes sense to at least print some debug message in cases when there is no matching channel number for a given task type. Change-Id: I34587b6c67015513de35d85a7a3291f452ee7f3b --- M src/target/firmware/layer1/mframe_sched.c 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/target/firmware/layer1/mframe_sched.c b/src/target/firmware/layer1/mframe_sched.c index f3a6b43..01ae167 100644 --- a/src/target/firmware/layer1/mframe_sched.c +++ b/src/target/firmware/layer1/mframe_sched.c @@ -400,10 +400,12 @@ case MF_TASK_TCH_H_1: cbits = 0x02 + 1; break; + case MF_TASK_UL_ALL_NB: - /* ERROR: cannot express as channel number */ - cbits = 0; - break; + default: + printd("ERROR: cannot express mf_task=%d as " + "channel number, using 0x00\n", mft); + cbits = 0x00; } return (cbits << 3) | (ts & 0x7); -- To view, visit https://gerrit.osmocom.org/11180 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I34587b6c67015513de35d85a7a3291f452ee7f3b Gerrit-Change-Number: 11180 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181003/16e1b650/attachment.htm>