Change in libosmocore[master]: mncc: Move definitions to header file

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Oct 3 08:24:13 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11185 )

Change subject: mncc: Move definitions to header file
......................................................................


Patch Set 3:

so in general, the most important goal is to keep as much as possible forward/backward compatibility.  So we cannot introduce build breakage in osmo-sip-connector or any other related program.  How that is solved, is left to the implementor.  It could be different naming, it could be "#ifndef ..." clauses or whatever elegang or not so elegant solution one may come up with.

the osmo_ prefix is generally required for new code/symbols/definitions going in libosmo*.  However, if the code extends/adds to existing code/symbols already present, and those alrady present don't have an osmo-prefix, then way stay bug-compatible to the old code.

So e.g. if gsm48_* functions are extended with a new function, the new one also just starts with gsm48_.


-- 
To view, visit https://gerrit.osmocom.org/11185
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I62bc025369bd9ee9b134e064a8364aa4bd5de16e
Gerrit-Change-Number: 11185
Gerrit-PatchSet: 3
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Wed, 03 Oct 2018 08:24:13 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181003/d1c96859/attachment.htm>


More information about the gerrit-log mailing list