Change in libosmocore[master]: mncc: Move definitions to header file

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11185 )

Change subject: mncc: Move definitions to header file
......................................................................


Patch Set 3:

> but wait.. are you sure about that?
 > so we've lived with gsm_mncc_bearer_cap for some time, for example.
 > But you're saying that gsm_mncc must become osmo_gsm_mncc now?

This is a problem of the current code in libosmocore - missing "osmo_"
prefixes for some symbols. Most likely, they were initially introduced
without that prefix, so now it's not easy (I would say no way) to add
this prefix, as it would break the API compatibility.

 > If one /were/ to do that work, you'ld also suggest that
 > gsm_mncc_bearer_cap should become osmo_gsm_mncc_bearer_cap ?

Let's introduce the new symbols with this prefix, as it anyway
would require some modifications in existing projects. This
at least wouldn't make the situation worse ;)

And let's see what does @LaF0rge think?


-- 
To view, visit https://gerrit.osmocom.org/11185
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I62bc025369bd9ee9b134e064a8364aa4bd5de16e
Gerrit-Change-Number: 11185
Gerrit-PatchSet: 3
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Tue, 02 Oct 2018 15:42:33 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181002/8e17d60b/attachment.htm>