Change in osmocom-bb[master]: firmware/layer1: add scheduler tasks for CBCH

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Mon Oct 1 20:18:28 UTC 2018


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11181 )

Change subject: firmware/layer1: add scheduler tasks for CBCH
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/11181/2/src/target/firmware/layer1/mframe_sched.c
File src/target/firmware/layer1/mframe_sched.c:

https://gerrit.osmocom.org/#/c/11181/2/src/target/firmware/layer1/mframe_sched.c@418
PS2, Line 418: 	case MF_TASK_SDCCH4_CBCH:
Oh, I think there should be a way to distinguish between both
tasks. What about the following:

  - MF_TASK_SDCCH4_CBCH - 0xc0 (0b11000 000)
  - MF_TASK_SDCCH8_CBCH - 0xc8 (0b11001 000)

The problem is that the following assumption:

  mf_task = (tn == 0) ?
    MF_TASK_SDCCH4_CBCH : MF_TASK_SDCCH8_CBCH;

is wrong, because SDCCH/8 can also be allocated on CX/TS0.
We need to find some way to distinguish both cases...



-- 
To view, visit https://gerrit.osmocom.org/11181
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d7f02cba1cd8f6527360589d2d2747b6426f78b
Gerrit-Change-Number: 11181
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Mon, 01 Oct 2018 20:18:28 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181001/043b0bef/attachment.htm>


More information about the gerrit-log mailing list