This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11995 ) Change subject: bsc: timeslot_fsm: Switch to error state before dispatching error event to lchans ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/11995/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/11995/2//COMMIT_MSG@9 PS2, Line 9: This way we receive tear down events such as TS_EV_CLHAN_UNUSED in a state prepared typo TS_EV_CLHAN_UNUSED https://gerrit.osmocom.org/#/c/11995/2//COMMIT_MSG@10 PS2, Line 10: to handle them, as a result from dispatching LCHAN_EV_TS_ERROR previously. > I don't understand: which state is unable to handle TS_EV_LCHAN_UNUSED? If it should be able to, the […] Unfortunately I forgot to add the log trace here for this one. It is most probably coming from the time I was testing DEACT NACK, so following your recommendations, we should add in ts_fsm_wait_pdch_deact similar stuff done in others states: case TS_EV_LCHAN_UNUSED: /* ignored */ return; Because otherwise it asserts in default case. -- To view, visit https://gerrit.osmocom.org/11995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If61493e7d5449bf2c2de9fd34cdf2410625e92ac Gerrit-Change-Number: 11995 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 30 Nov 2018 17:42:21 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181130/457ab786/attachment.htm>