Change in osmo-bsc[master]: bsc: timelost_fsm: Remove unneeded set of out variable on failure

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Fri Nov 30 17:23:02 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11981 )

Change subject: bsc: timelost_fsm: Remove unneeded set of out variable on failure
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/11981/2/src/osmo-bsc/timeslot_fsm.c
File src/osmo-bsc/timeslot_fsm.c:

https://gerrit.osmocom.org/#/c/11981/2/src/osmo-bsc/timeslot_fsm.c@867
PS2, Line 867: 	return false;
> my idea here was to avoid leaving a value in an uninitialized state. […]
It's really not needed and it just adds extra code for no reason, since it's not the purpose of the function.



-- 
To view, visit https://gerrit.osmocom.org/11981
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8f9b7e1f584dee885d6823dc043682577572bd8
Gerrit-Change-Number: 11981
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Fri, 30 Nov 2018 17:23:02 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181130/fb8c1243/attachment.htm>


More information about the gerrit-log mailing list