Change in libosmocore[master]: LCLS: fix GCR parameter type

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Nov 30 15:58:05 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12019 )

Change subject: LCLS: fix GCR parameter type
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

still: please explain why this commit log mismatches the patch completely.
I get tired of asking the same stuff.

https://gerrit.osmocom.org/#/c/12019/3/include/osmocom/gsm/gsm0808_utils.h
File include/osmocom/gsm/gsm0808_utils.h:

https://gerrit.osmocom.org/#/c/12019/3/include/osmocom/gsm/gsm0808_utils.h@64
PS3, Line 64: 	enum gsm0808_lcls_control control; /*< doc  §3.2.2.117 Connection Status Control */
hah no, don't write "doc"! Please read the doxygen documentation to familiarize yourself with the comment styles
  /*! ... */
  /*< ... */



-- 
To view, visit https://gerrit.osmocom.org/12019
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ccfbd0c146e462e599e5305520cc89602364ec3
Gerrit-Change-Number: 12019
Gerrit-PatchSet: 4
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 30 Nov 2018 15:58:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181130/7da574dc/attachment.html>


More information about the gerrit-log mailing list