Change in libosmocore[master]: LCLS, TS 29.205: add GCR routines

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/11827 )

Change subject: LCLS, TS 29.205: add GCR routines
......................................................................


Patch Set 9:

(3 comments)

The rest should be addressed in next revision.

https://gerrit.osmocom.org/#/c/11827/9/src/gsm/gsm29_205.c
File src/gsm/gsm29_205.c:

https://gerrit.osmocom.org/#/c/11827/9/src/gsm/gsm29_205.c@82
PS9, Line 82: 	parsed += (2 + 1);
> parenthesis can be dropped here.
I think it would reduce readability so I'd rather keep them.


https://gerrit.osmocom.org/#/c/11827/9/src/gsm/libosmogsm.map
File src/gsm/libosmogsm.map:

https://gerrit.osmocom.org/#/c/11827/9/src/gsm/libosmogsm.map@147
PS9, Line 147: gsm29205_enc_gcr;
> I know not everything is perfectly sorted, but let's try to keep it as sorted as possible, so move t […]
Curious, why it should be sorted at all? I thought this file is loaded completely by linker and entries order does not matter.


https://gerrit.osmocom.org/#/c/11827/9/tests/gsm29205/gsm29205_test.c
File tests/gsm29205/gsm29205_test.c:

https://gerrit.osmocom.org/#/c/11827/9/tests/gsm29205/gsm29205_test.c@64
PS9, Line 64: 		printf("decoding failed: %s [%s]\n", strerror(-rc), msgb_hexdump(msg));
> All these should exit, or at least return.
Why? Printing unexpected text on the screen will cause test failure just like unexpected exit. At the same time running till the end of the test allows us to see multiple errors at once.



-- 
To view, visit https://gerrit.osmocom.org/11827
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee95aa4e5c056645b6cb5667e4a067097d52dfbf
Gerrit-Change-Number: 11827
Gerrit-PatchSet: 9
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 30 Nov 2018 14:57:39 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181130/5e7bd069/attachment.htm>