Change in libosmocore[master]: msgb: add test helpers

Max gerrit-no-reply at lists.osmocom.org
Fri Nov 30 14:54:09 UTC 2018


Max has posted comments on this change. ( https://gerrit.osmocom.org/12017 )

Change subject: msgb: add test helpers
......................................................................


Patch Set 2:

> what about having it return an int like memcmp?

What for?

> after all we are using memcmp, so we can return an in

That would be pretty useless - I've yet to see the use-case where it would be necessary. It will also make API cumbersome and counter-intuitive because we not only use memcmp() but also compare lengths and check data availability. In fact, memcmp() might not be called at all.

The rest should be addressed in next revision.


-- 
To view, visit https://gerrit.osmocom.org/12017
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3bc95f2f5ab6e3f4b502647fb3e0aaaf1f7c4cf5
Gerrit-Change-Number: 12017
Gerrit-PatchSet: 2
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 30 Nov 2018 14:54:09 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181130/0a74fffd/attachment.html>


More information about the gerrit-log mailing list