Change in osmo-msc[master]: rename gsm_encr to geran_encr, it is only applicable on GERAN

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Nov 30 14:35:21 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12039 )

Change subject: rename gsm_encr to geran_encr, it is only applicable on GERAN
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/12039/2/include/osmocom/msc/common_cs.h
File include/osmocom/msc/common_cs.h:

https://gerrit.osmocom.org/#/c/12039/2/include/osmocom/msc/common_cs.h@12
PS2, Line 12: geran_encr
> Maybe we could even move this definition into the 'gsm_subscriber_connection' struct definition? (un […]
I thought it was a good idea and applied it, but then saw that I can't do this anymore:

  conn->geran_encr = (struct geran_encr){};

so leaving it separate now.



-- 
To view, visit https://gerrit.osmocom.org/12039
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc7ca9da1aa13ae16f5db2cb1024676cbc770820
Gerrit-Change-Number: 12039
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 30 Nov 2018 14:35:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181130/7e887c56/attachment.html>


More information about the gerrit-log mailing list