Change in libosmocore[master]: LCLS, TS 48.008: add GCR IE encoding/decoding

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Fri Nov 30 13:26:51 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12020 )

Change subject: LCLS, TS 48.008: add GCR IE encoding/decoding
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/#/c/12020/2/src/gsm/gsm0808_utils.c
File src/gsm/gsm0808_utils.c:

https://gerrit.osmocom.org/#/c/12020/2/src/gsm/gsm0808_utils.c@496
PS2, Line 496: 	msgb_v_put(msg, 0); /* len points to this reserved space already */
/* reserve space for length, len points to this reserved space already */
	msgb_v_put(msg, 0);


https://gerrit.osmocom.org/#/c/12020/2/tests/gsm0808/gsm0808_test.c
File tests/gsm0808/gsm0808_test.c:

https://gerrit.osmocom.org/#/c/12020/2/tests/gsm0808/gsm0808_test.c@600
PS2, Line 600: 	if (!msgb_cmpr(__func__, __LINE__, msg, res, ARRAY_SIZE(res), true))
Same comments as before: msgb_cmp, etc.


https://gerrit.osmocom.org/#/c/12020/2/tests/gsm0808/gsm0808_test.c@605
PS2, Line 605: 		printf("parsing failed: %s [%s]\n", strerror(-rc), msgb_hexdump(msg));
Exit or at last return in all failed cases.



-- 
To view, visit https://gerrit.osmocom.org/12020
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82ce0207dc8de50689a8806c6471ad7fbae6219d
Gerrit-Change-Number: 12020
Gerrit-PatchSet: 2
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 30 Nov 2018 13:26:51 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181130/5ce05391/attachment.html>


More information about the gerrit-log mailing list