Change in libosmocore[master]: LCLS: fix GCR parameter name

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Fri Nov 30 12:19:17 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12019 )

Change subject: LCLS: fix GCR parameter name
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12019/1/include/osmocom/gsm/gsm0808_utils.h
File include/osmocom/gsm/gsm0808_utils.h:

https://gerrit.osmocom.org/#/c/12019/1/include/osmocom/gsm/gsm0808_utils.h@65
PS1, Line 65: 	struct gsm29205_gcr *gcr;          /*< doc  §3.2.2.115 Global Call Reference */
In the previous commit, "struct gsm29205_gcr" is added. Can we remove "struct gsm0808_gcr" since it's no longer of any use, or is it being used somehwere still?



-- 
To view, visit https://gerrit.osmocom.org/12019
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ccfbd0c146e462e599e5305520cc89602364ec3
Gerrit-Change-Number: 12019
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 30 Nov 2018 12:19:17 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181130/29cbf6b8/attachment.html>


More information about the gerrit-log mailing list