Change in osmo-hlr[master]: SS/USSD: fix: properly (re)schedule SS session timeout

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Fri Nov 30 12:03:37 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12022 )

Change subject: SS/USSD: fix: properly (re)schedule SS session timeout
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/12022/3/src/hlr_ussd.c
File src/hlr_ussd.c:

https://gerrit.osmocom.org/#/c/12022/3/src/hlr_ussd.c@542
PS3, Line 542: 		/* Reschedule self-destruction timer */
Can we split adding the VTY command and adding this block into separate commits? One is a feature and the other one is a fix.


https://gerrit.osmocom.org/#/c/12022/3/src/hlr_vty.c
File src/hlr_vty.c:

https://gerrit.osmocom.org/#/c/12022/3/src/hlr_vty.c@291
PS3, Line 291: 	if (g_hlr->ss_guard_timeout > 0)
Can we have a defin for SS_GUARD_TIMEOUT_DEFAULT 30, then use it in hlr.c to set the default, and then here have:

if (g_hlr->ss_guard_timeout > 0 && g_hlr->ss_guard_timeout != SS_GUARD_TIMEOUT_DEFAULT)



-- 
To view, visit https://gerrit.osmocom.org/12022
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00561c7aa692b19f85692e11f83ffc1826023120
Gerrit-Change-Number: 12022
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 30 Nov 2018 12:03:37 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181130/7ed9f0ba/attachment.html>


More information about the gerrit-log mailing list