Change in osmo-msc[master]: combine several small .h in msc_common.h

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Fri Nov 30 10:32:16 UTC 2018


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12033 )

Change subject: combine several small .h in msc_common.h
......................................................................


Patch Set 4:

(3 comments)

https://gerrit.osmocom.org/#/c/12033/4/include/osmocom/msc/debug.h
File include/osmocom/msc/debug.h:

https://gerrit.osmocom.org/#/c/12033/4/include/osmocom/msc/debug.h@a6
PS4, Line 6: 
I would keep logging related stuff separately...


https://gerrit.osmocom.org/#/c/12033/4/include/osmocom/msc/msc_common.h
File include/osmocom/msc/msc_common.h:

https://gerrit.osmocom.org/#/c/12033/4/include/osmocom/msc/msc_common.h@7
PS4, Line 7: #define MSC_HLR_REMOTE_IP_DEFAULT "127.0.0.1"
           : #define MSC_HLR_REMOTE_PORT_DEFAULT OSMO_GSUP_PORT
This is rather VLR specific stuff, because exactly VLR speaks GSUP with HLR.


https://gerrit.osmocom.org/#/c/12033/4/include/osmocom/msc/msc_common.h@10
PS4, Line 10: msc_debug_categories
Do we really need to name this enum? It isn't referenced anywhere AFAIK.
Also, it goes beyond the commit's main idea.



-- 
To view, visit https://gerrit.osmocom.org/12033
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e3a587342f8d398fb27354a2f2475f8797cdb28
Gerrit-Change-Number: 12033
Gerrit-PatchSet: 4
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 30 Nov 2018 10:32:16 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181130/f32a537c/attachment.html>


More information about the gerrit-log mailing list