Change in osmo-msc[master]: drop unused tests/db/*

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Nov 30 02:45:46 UTC 2018


Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/12027


Change subject: drop unused tests/db/*
......................................................................

drop unused tests/db/*

Another one of those "what is this still doing here". Not mentioned in
configure.ac nor Makefile.am SUBDIR...

Change-Id: I05880507d9bf029f0ec451efda0ebe54ac09ef12
---
D tests/db/Makefile.am
D tests/db/db_test.c
D tests/db/db_test.err
D tests/db/db_test.ok
D tests/db/hlr.sqlite3
5 files changed, 0 insertions(+), 337 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/27/12027/1

diff --git a/tests/db/Makefile.am b/tests/db/Makefile.am
deleted file mode 100644
index 249a873..0000000
--- a/tests/db/Makefile.am
+++ /dev/null
@@ -1,44 +0,0 @@
-AM_CPPFLAGS = \
-	$(all_includes) \
-	-I$(top_srcdir)/include \
-	$(NULL)
-
-AM_CFLAGS = \
-	-Wall \
-	-ggdb3 \
-	$(LIBOSMOCORE_CFLAGS) \
-	$(LIBOSMOGSM_CFLAGS) \
-	$(LIBOSMOABIS_CFLAGS) \
-	$(LIBSMPP34_CFLAGS) \
-	$(COVERAGE_CFLAGS) \
-	$(NULL)
-
-AM_LDFLAGS = \
-	$(COVERAGE_LDFLAGS) \
-	$(NULL)
-
-EXTRA_DIST = \
-	db_test.ok \
-	db_test.err \
-	hlr.sqlite3 \
-	$(NULL)
-
-noinst_PROGRAMS = \
-	db_test \
-	$(NULL)
-
-db_test_SOURCES = \
-	db_test.c \
-	$(NULL)
-
-db_test_LDADD = \
-	$(top_builddir)/src/libmsc/libmsc.a \
-	$(top_builddir)/src/libtrau/libtrau.a \
-	$(top_builddir)/tests/libiudummy/libiudummy.a \
-	$(LIBOSMOCORE_LIBS) \
-	$(LIBOSMOABIS_LIBS) \
-	$(LIBOSMOGSM_LIBS) \
-	$(LIBSMPP34_LIBS) \
-	$(LIBOSMOVTY_LIBS) \
-	-ldbi \
-	$(NULL)
diff --git a/tests/db/db_test.c b/tests/db/db_test.c
deleted file mode 100644
index 63099f6..0000000
--- a/tests/db/db_test.c
+++ /dev/null
@@ -1,286 +0,0 @@
-/* (C) 2008 by Jan Luebbe <jluebbe at debian.org>
- * (C) 2009-2016 by Holger Hans Peter Freyther <zecke at selfish.org>
- * (C) 2014 by Alexander Chemeris <Alexander.Chemeris at fairwaves.co>
- * All Rights Reserved
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License as published by
- * the Free Software Foundation; either version 3 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- *
- */
-
-#include <osmocom/msc/debug.h>
-#include <osmocom/msc/db.h>
-#include <osmocom/msc/gsm_subscriber.h>
-#include <osmocom/msc/gsm_04_11.h>
-#include <osmocom/msc/mgcp.h>
-
-#include <osmocom/core/application.h>
-
-#include <stdio.h>
-#include <string.h>
-#include <stdlib.h>
-#include <stdbool.h>
-#include <inttypes.h>
-
-static struct gsm_network dummy_net;
-static struct gsm_subscriber_group dummy_sgrp;
-
-#define SUBSCR_PUT(sub) \
-	sub->group = &dummy_sgrp;	\
-	subscr_put(sub);
-
-#define COMPARE(original, copy) \
-	if (original->id != copy->id) \
-		printf("Ids do not match in %s:%d %llu %llu\n", \
-			__FUNCTION__, __LINE__, original->id, copy->id); \
-	if (original->lac != copy->lac) \
-		printf("LAC do not match in %s:%d %d %d\n", \
-			__FUNCTION__, __LINE__, original->lac, copy->lac); \
-	if (original->authorized != copy->authorized) \
-		printf("Authorize do not match in %s:%d %d %d\n", \
-			__FUNCTION__, __LINE__, original->authorized, \
-			copy->authorized); \
-	if (strcmp(original->imsi, copy->imsi) != 0) \
-		printf("IMSIs do not match in %s:%d '%s' '%s'\n", \
-			__FUNCTION__, __LINE__, original->imsi, copy->imsi); \
-	if (original->tmsi != copy->tmsi) \
-		printf("TMSIs do not match in %s:%d '%u' '%u'\n", \
-			__FUNCTION__, __LINE__, original->tmsi, copy->tmsi); \
-	if (strcmp(original->name, copy->name) != 0) \
-		printf("names do not match in %s:%d '%s' '%s'\n", \
-			__FUNCTION__, __LINE__, original->name, copy->name); \
-	if (strcmp(original->extension, copy->extension) != 0) \
-		printf("Extensions do not match in %s:%d '%s' '%s'\n", \
-			__FUNCTION__, __LINE__, original->extension, copy->extension); \
-
-/*
- * Create/Store a SMS and then try to load it.
- */
-static void test_sms(void)
-{
-	int rc;
-	struct gsm_sms *sms;
-	struct gsm_subscriber *subscr;
-	subscr = db_get_subscriber(GSM_SUBSCRIBER_IMSI, "9993245423445");
-	OSMO_ASSERT(subscr);
-	subscr->group = &dummy_sgrp;
-
-	sms = sms_alloc();
-	sms->receiver = subscr_get(subscr);
-
-	sms->src.ton = 0x23;
-	sms->src.npi = 0x24;
-	memcpy(sms->src.addr, "1234", strlen("1234") + 1);
-
-	sms->dst.ton = 0x32;
-	sms->dst.npi = 0x42;
-	memcpy(sms->dst.addr, subscr->extension, sizeof(subscr->extension));
-
-	memcpy(sms->text, "Text123", strlen("Text123") + 1);
-	memcpy(sms->user_data, "UserData123", strlen("UserData123") + 1);
-	sms->user_data_len = strlen("UserData123");
-
-	/* random values */
-	sms->reply_path_req = 1;
-	sms->status_rep_req = 2;
-	sms->ud_hdr_ind = 3;
-	sms->protocol_id = 4;
-	sms->data_coding_scheme = 5;
-
-	rc = db_sms_store(sms);
-	sms_free(sms);
-	OSMO_ASSERT(rc == 0);
-
-	/* now query */
-	sms = db_sms_get_unsent_for_subscr(subscr);
-	OSMO_ASSERT(sms);
-	OSMO_ASSERT(sms->receiver == subscr);
-	OSMO_ASSERT(sms->reply_path_req == 1);
-	OSMO_ASSERT(sms->status_rep_req == 2);
-	OSMO_ASSERT(sms->ud_hdr_ind == 3);
-	OSMO_ASSERT(sms->protocol_id == 4);
-	OSMO_ASSERT(sms->data_coding_scheme == 5);
-	OSMO_ASSERT(sms->src.ton == 0x23);
-	OSMO_ASSERT(sms->src.npi == 0x24);
-	OSMO_ASSERT(sms->dst.ton == 0x32);
-	OSMO_ASSERT(sms->dst.npi == 0x42);
-	OSMO_ASSERT(strcmp((char *) sms->text, "Text123") == 0);
-	OSMO_ASSERT(sms->user_data_len == strlen("UserData123"));
-	OSMO_ASSERT(strcmp((char *) sms->user_data, "UserData123") == 0);
-
-	/* Mark the SMS as delivered */
-	db_sms_mark_delivered(sms);
-	sms_free(sms);
-
-	sms = db_sms_get_unsent_for_subscr(subscr);
-	OSMO_ASSERT(!sms);
-
-	subscr_put(subscr);
-}
-
-static void test_sms_migrate(void)
-{
-	struct gsm_subscriber *rcv_subscr;
-	struct gsm_sms *sms;
-	static const uint8_t user_data_1[] = {
-		0x41, 0xf1, 0xd8, 0x05, 0x22, 0x96, 0xcd, 0x2e,
-		0x90, 0xf1, 0xfd, 0x06, 0x00 };
-	static const uint8_t user_data_2[] = {
-		0x41, 0xf1, 0xd8, 0x05, 0x22, 0x96, 0xcd, 0x2e,
-		0xd0, 0xf1, 0xfd, 0x06, 0x00 };
-
-	rcv_subscr = db_get_subscriber(GSM_SUBSCRIBER_IMSI, "901010000001111");
-	rcv_subscr->group = &dummy_sgrp;
-
-	sms = db_sms_get(&dummy_net, 1);
-	OSMO_ASSERT(sms->id == 1);
-	OSMO_ASSERT(sms->receiver == rcv_subscr);
-	OSMO_ASSERT(strcmp(sms->text, "Abc. Def. Foo") == 0);
-	OSMO_ASSERT(sms->user_data_len == ARRAY_SIZE(user_data_1));
-	OSMO_ASSERT(memcmp(sms->user_data, user_data_1, ARRAY_SIZE(user_data_1)) == 0);
-	sms_free(sms);
-
-	sms = db_sms_get(&dummy_net, 2);
-	OSMO_ASSERT(sms->id == 2);
-	OSMO_ASSERT(sms->receiver == rcv_subscr);
-	OSMO_ASSERT(strcmp(sms->text, "Abc. Def. Goo") == 0);
-	OSMO_ASSERT(sms->user_data_len == ARRAY_SIZE(user_data_2));
-	OSMO_ASSERT(memcmp(sms->user_data, user_data_2, ARRAY_SIZE(user_data_2)) == 0);
-	sms_free(sms);
-
-	subscr_put(rcv_subscr);
-}
-
-static void test_subs(const char *imsi, char *imei1, char *imei2, bool make_ext)
-{
-	struct gsm_subscriber *alice = NULL, *alice_db;
-	char scratch_str[256];
-
-	alice = db_create_subscriber(imsi, GSM_MIN_EXTEN, GSM_MAX_EXTEN,
-				     make_ext);
-	db_subscriber_assoc_imei(alice, imei1);
-	if (imei2)
-		db_subscriber_assoc_imei(alice, imei2);
-	db_subscriber_alloc_tmsi(alice);
-	alice->lac=42;
-	db_sync_subscriber(alice);
-	/* Get by TMSI */
-	snprintf(scratch_str, sizeof(scratch_str), "%"PRIu32, alice->tmsi);
-	alice_db = db_get_subscriber(GSM_SUBSCRIBER_TMSI, scratch_str);
-	COMPARE(alice, alice_db);
-	SUBSCR_PUT(alice_db);
-	/* Get by IMSI */
-	alice_db = db_get_subscriber(GSM_SUBSCRIBER_IMSI, imsi);
-	COMPARE(alice, alice_db);
-	SUBSCR_PUT(alice_db);
-	/* Get by id */
-	snprintf(scratch_str, sizeof(scratch_str), "%llu", alice->id);
-	alice_db = db_get_subscriber(GSM_SUBSCRIBER_ID, scratch_str);
-	COMPARE(alice, alice_db);
-	SUBSCR_PUT(alice_db);
-	/* Get by extension */
-	alice_db = db_get_subscriber(GSM_SUBSCRIBER_EXTENSION, alice->extension);
-	if (alice_db) {
-		if (!make_ext)
-			printf("FAIL: bogus extension created for IMSI %s\n",
-			       imsi);
-		COMPARE(alice, alice_db);
-		SUBSCR_PUT(alice_db);
-	} else if (make_ext)
-		printf("FAIL: no subscriber extension for IMSI %s\n", imsi);
-	SUBSCR_PUT(alice);
-}
-
-int main()
-{
-	printf("Testing subscriber database code.\n");
-	osmo_init_logging(&log_info);
-	log_set_print_filename(osmo_stderr_target, 0);
-
-	dummy_net.subscr_group = &dummy_sgrp;
-	dummy_sgrp.net         = &dummy_net;
-
-	if (db_init("hlr.sqlite3")) {
-		printf("DB: Failed to init database. Please check the option settings.\n");
-		return 1;
-	}	 
-	printf("DB: Database initialized.\n");
-
-	if (db_prepare()) {
-		printf("DB: Failed to prepare database.\n");
-		return 1;
-	}
-	printf("DB: Database prepared.\n");
-
-	struct gsm_subscriber *alice = NULL;
-	struct gsm_subscriber *alice_db;
-
-	char *alice_imsi = "3243245432345";
-	alice = db_create_subscriber(alice_imsi, GSM_MIN_EXTEN, GSM_MAX_EXTEN,
-				     true);
-	db_sync_subscriber(alice);
-	alice_db = db_get_subscriber(GSM_SUBSCRIBER_IMSI, alice->imsi);
-	COMPARE(alice, alice_db);
-	SUBSCR_PUT(alice_db);
-	SUBSCR_PUT(alice);
-
-	test_subs("3693245423445", "1234567890", NULL, true);
-	test_subs("9993245423445", "1234567890", "6543560920", true);
-	test_subs("3123122223445", "1234567890", NULL, false);
-	test_subs("9123121223445", "1234567890", "6543560920", false);
-
-	/* create it again and see it fails */
-	alice = db_create_subscriber(alice_imsi, GSM_MIN_EXTEN, GSM_MAX_EXTEN,
-				     true);
-	OSMO_ASSERT(!alice);
-
-	test_sms();
-	test_sms_migrate();
-
-	db_fini();
-
-	printf("Done\n");
-	return 0;
-}
-
-/* stubs */
-void vty_out() {}
-void vlr_subscr_disconnected() {}
-void vlr_subscr_rx_tmsi_reall_compl() {}
-void vlr_subscr_rx_id_resp() {}
-void vlr_subscr_rx_auth_resp() {}
-void vlr_loc_update() {}
-void vlr_proc_acc_req() {}
-void vlr_init() {}
-unsigned int mgcpgw_client_next_endpoint(struct mgcpgw_client *client)
-{ return 0; }
-struct msgb *mgcp_msg_crcx(struct mgcpgw_client *mgcp,
-			   uint16_t rtp_endpoint, unsigned int call_id,
-			   enum mgcp_connection_mode mode)
-{ return NULL; }
-struct msgb *mgcp_msg_mdcx(struct mgcpgw_client *mgcp,
-			   uint16_t rtp_endpoint, const char *rtp_conn_addr,
-			   uint16_t rtp_port, enum mgcp_connection_mode mode)
-{ return NULL; }
-int mgcpgw_client_tx(struct mgcpgw_client *mgcp, struct msgb *msg,
-		     mgcp_response_cb_t response_cb, void *priv)
-{ return -EINVAL; }
-const char *mgcpgw_client_remote_addr_str(struct mgcpgw_client *mgcp)
-{ return "0.0.0.0"; }
-uint32_t mgcpgw_client_remote_addr_n(struct mgcpgw_client *mgcp)
-{ return 0; }
-int mgcp_response_parse_params(struct mgcp_response *r)
-{ return -EINVAL; }
-struct RANAP_Cause;
-int iu_tx_release(struct ue_conn_ctx *ctx, const struct RANAP_Cause *cause)
-{ return 0; }
diff --git a/tests/db/db_test.err b/tests/db/db_test.err
deleted file mode 100644
index 27e5703..0000000
--- a/tests/db/db_test.err
+++ /dev/null
@@ -1,3 +0,0 @@
-Going to migrate from revision 3
-Going to migrate from revision 4
-
\ No newline at end of file
diff --git a/tests/db/db_test.ok b/tests/db/db_test.ok
deleted file mode 100644
index 2632a8c..0000000
--- a/tests/db/db_test.ok
+++ /dev/null
@@ -1,4 +0,0 @@
-Testing subscriber database code.
-DB: Database initialized.
-DB: Database prepared.
-Done
diff --git a/tests/db/hlr.sqlite3 b/tests/db/hlr.sqlite3
deleted file mode 100644
index e59dcdc..0000000
--- a/tests/db/hlr.sqlite3
+++ /dev/null
Binary files differ

-- 
To view, visit https://gerrit.osmocom.org/12027
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I05880507d9bf029f0ec451efda0ebe54ac09ef12
Gerrit-Change-Number: 12027
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181130/d28382ad/attachment.htm>


More information about the gerrit-log mailing list