Change in osmo-trx[master]: lms: User correct scale factor for transmit samples

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Nov 29 14:20:19 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12006 )

Change subject: lms: User correct scale factor for transmit samples
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/12006/2/Transceiver52M/device/lms/LMSDevice.h
File Transceiver52M/device/lms/LMSDevice.h:

https://gerrit.osmocom.org/#/c/12006/2/Transceiver52M/device/lms/LMSDevice.h@38
PS2, Line 38: #define LIMESDR_TX_AMPL  0.707
I cannot really say I know enough about the topic to really say whether this good or wrong, but whoever did it seems to know it well :-P



-- 
To view, visit https://gerrit.osmocom.org/12006
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I71702feaa11f53e7614a6938a984dd748405474a
Gerrit-Change-Number: 12006
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Nov 2018 14:20:19 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181129/e35db8ac/attachment.html>


More information about the gerrit-log mailing list