This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12009 ) Change subject: gprs/gprs_gmm: implement T3314. Timeout to reset MM state to STANDBY ...................................................................... Patch Set 1: Code-Review-1 (3 comments) https://gerrit.osmocom.org/#/c/12009/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/12009/1//COMMIT_MSG@9 PS1, Line 9: When a MS MM state is READY the exakt location is known (PCU). typo: exact. https://gerrit.osmocom.org/#/c/12009/1/include/osmocom/sgsn/gprs_sgsn.h File include/osmocom/sgsn/gprs_sgsn.h: https://gerrit.osmocom.org/#/c/12009/1/include/osmocom/sgsn/gprs_sgsn.h@230 PS1, Line 230: unsigned int state_T; /* Txxxx number but only used for pmm_states */ Is this really needed? Are there more than one timer going to be handled by state_timer? Can we rename state_timer to T3314 maybe? https://gerrit.osmocom.org/#/c/12009/1/src/gprs/gprs_gmm.c File src/gprs/gprs_gmm.c: https://gerrit.osmocom.org/#/c/12009/1/src/gprs/gprs_gmm.c@2975 PS1, Line 2975: void gsm0408_gprs_notify_pdu_gb(struct msgb *msg) This newly added function seems to be never called anywhere, and as a result newly added function mmctx_recv_pdu is neither called. -- To view, visit https://gerrit.osmocom.org/12009 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ce23ebe50d141076c20c9c56990b7103cd25e55 Gerrit-Change-Number: 12009 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-Comment-Date: Thu, 29 Nov 2018 14:05:46 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181129/cbc53e47/attachment.htm>