Change in osmo-bsc[master]: bsc: timeslot_fsm: Switch to error state before dispatching error eve...

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Wed Nov 28 20:31:15 UTC 2018


Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11995


Change subject: bsc: timeslot_fsm: Switch to error state before dispatching error event to lchans
......................................................................

bsc: timeslot_fsm: Switch to error state before dispatching error event to lchans

This way we receive tear down events such as TS_EV_CLHAN_UNUSED in a state prepared
to handle them, as a result from dispatching LCHAN_EV_TS_ERROR previously.

Change-Id: If61493e7d5449bf2c2de9fd34cdf2410625e92ac
---
M src/osmo-bsc/timeslot_fsm.c
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/95/11995/1

diff --git a/src/osmo-bsc/timeslot_fsm.c b/src/osmo-bsc/timeslot_fsm.c
index e3327b7..952df72 100644
--- a/src/osmo-bsc/timeslot_fsm.c
+++ b/src/osmo-bsc/timeslot_fsm.c
@@ -171,9 +171,10 @@
 	if (errmsg)
 		LOG_TS(ts, LOGL_ERROR, "%s\n", errmsg);
 
-	ts_lchans_dispatch(ts, LCHAN_ST_WAIT_TS_READY, LCHAN_EV_TS_ERROR);
 	if (fi->state != state_chg)
 		osmo_fsm_inst_state_chg(fi, state_chg, 0, 0);
+
+	ts_lchans_dispatch(ts, LCHAN_ST_WAIT_TS_READY, LCHAN_EV_TS_ERROR);
 }
 
 static void ts_fsm_err_ready_to_go_in_pdch(struct osmo_fsm_inst *fi, struct gsm_lchan *lchan)

-- 
To view, visit https://gerrit.osmocom.org/11995
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If61493e7d5449bf2c2de9fd34cdf2410625e92ac
Gerrit-Change-Number: 11995
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181128/0b70a9db/attachment.html>


More information about the gerrit-log mailing list