Change in python/osmo-python-tests[master]: ctrl2cgi: fix deferred callbacks

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Wed Nov 28 12:31:21 UTC 2018


Max has posted comments on this change. ( https://gerrit.osmocom.org/11953 )

Change subject: ctrl2cgi: fix deferred callbacks
......................................................................


Patch Set 3:

(1 comment)

The very point of this commit is to get rid of "yield" calls in this function which fixes all the issues I've seen before while testing locally. So if we actually need this error code than I can try to come up with a way of checking it. But it'll be separate commit or patch series. Which should be carefully tested not to break async semantics again.

https://gerrit.osmocom.org/#/c/11953/3/scripts/ctrl2cgi.py
File scripts/ctrl2cgi.py:

https://gerrit.osmocom.org/#/c/11953/3/scripts/ctrl2cgi.py@a51
PS3, Line 51: 
> This resp.code stuff can still be used after changes in this commit

No, it can not. The resp is a simple byte sequence which have neither .code nor .body - please have a look at code change.



-- 
To view, visit https://gerrit.osmocom.org/11953
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2c28dd7f79cbd28d475de93750703659ddd18f1
Gerrit-Change-Number: 11953
Gerrit-PatchSet: 3
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Comment-Date: Wed, 28 Nov 2018 12:31:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181128/8a2a3f94/attachment.htm>


More information about the gerrit-log mailing list