Change in osmo-bsc[master]: cosmetic: bsc: timeslot_fsm: Clean uneeded scope brackets

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Nov 27 22:37:53 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11955 )

Change subject: cosmetic: bsc: timeslot_fsm: Clean uneeded scope brackets
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

In my opinion, the scope nicely indicates that the struct is only used for signaling the other function, but we had this discussion before and I was overruled.

https://gerrit.osmocom.org/#/c/11955/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11955/1//COMMIT_MSG@7
PS1, Line 7: cosmetic: bsc: timeslot_fsm: Clean uneeded scope brackets
and omit uneeded n?



-- 
To view, visit https://gerrit.osmocom.org/11955
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5140f98e23b8c8d16ce0cca0be66297aaf0b5653
Gerrit-Change-Number: 11955
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Tue, 27 Nov 2018 22:37:53 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181127/c3fdb9f3/attachment.htm>


More information about the gerrit-log mailing list