Change in python/osmo-python-tests[master]: osmo_ctrl.py: properly ignore out-of-order traps

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Nov 27 22:33:39 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11909 )

Change subject: osmo_ctrl.py: properly ignore out-of-order traps
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

(leaving +2 to pespin)

https://gerrit.osmocom.org/#/c/11909/4/scripts/osmo_ctrl.py
File scripts/osmo_ctrl.py:

https://gerrit.osmocom.org/#/c/11909/4/scripts/osmo_ctrl.py@47
PS4, Line 47:                 if ret != None:
(I'd even prefer 'if ret == None: continue' but nm)



-- 
To view, visit https://gerrit.osmocom.org/11909
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6de02c2f13a56f0381c97a9ab02c6c7a31cc32f
Gerrit-Change-Number: 11909
Gerrit-PatchSet: 4
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Comment-Date: Tue, 27 Nov 2018 22:33:39 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181127/05b879e9/attachment.htm>


More information about the gerrit-log mailing list