Change in osmo-ttcn3-hacks[master]: bsc: Start the timer at the beginning of f_init

daniel gerrit-no-reply at lists.osmocom.org
Tue Nov 27 17:06:26 UTC 2018


daniel has submitted this change and it was merged. ( https://gerrit.osmocom.org/11950 )

Change subject: bsc: Start the timer at the beginning of f_init
......................................................................

bsc: Start the timer at the beginning of f_init

This avoids a possible indefinite timeout if osmo-bsc crashes during the
test.

Ticket: OS#3713

Change-Id: I88f6254d9d2d90ab49a3c3d8255af25ca6ffe624
---
M bsc/BSC_Tests.ttcn
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, approved



diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 53e4396..962d6c6 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -310,6 +310,9 @@
 	}
 	g_initialized := true;
 
+	T_guard.start;
+	activate(as_Tguard());
+
 	/* Call a function of our 'parent component' BSSAP_Adapter_CT to start the
 	 * MSC-side BSSAP emulation */
 	if (handler_mode) {
@@ -336,8 +339,6 @@
 		f_wait_oml(i, "connected", 5.0);
 	}
 
-	T_guard.start;
-	activate(as_Tguard());
 }
 
 /* expect to receive a RSL message matching a specified template on a given BTS / stream */

-- 
To view, visit https://gerrit.osmocom.org/11950
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I88f6254d9d2d90ab49a3c3d8255af25ca6ffe624
Gerrit-Change-Number: 11950
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181127/abbc27a2/attachment.html>


More information about the gerrit-log mailing list