Change in cellmgr-ng[master]: vty: skip installing cmds now always installed by default

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Nov 27 15:34:17 UTC 2018


Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/4605 )

Change subject: vty: skip installing cmds now always installed by default
......................................................................

vty: skip installing cmds now always installed by default

Depends: I5021c64a787b63314e0f2f1cba0b8fc7bff4f09b
Change-Id: I0fc8142756040c98c1862ddb18a77a032f2a7143
---
M src/mgcp/mgcp_vty.c
M src/vty_interface.c
2 files changed, 0 insertions(+), 31 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved



diff --git a/src/mgcp/mgcp_vty.c b/src/mgcp/mgcp_vty.c
index dfcc6fe..85c70c5 100644
--- a/src/mgcp/mgcp_vty.c
+++ b/src/mgcp/mgcp_vty.c
@@ -858,7 +858,6 @@
 	install_element(CONFIG_NODE, &cfg_mgcp_cmd);
 	install_node(&mgcp_node, config_write_mgcp);
 
-	install_default(MGCP_NODE);
 	install_element(MGCP_NODE, &ournode_exit_cmd);
 	install_element(MGCP_NODE, &ournode_end_cmd);
 	install_element(MGCP_NODE, &cfg_mgcp_local_ip_cmd);
@@ -883,7 +882,6 @@
 
 	install_element(MGCP_NODE, &cfg_mgcp_vtrunk_cmd);
 	install_node(&vtrunk_node, config_write_vtrunk);
-	install_default(VTRUNK_NODE);
 	install_element(VTRUNK_NODE, &ournode_exit_cmd);
 	install_element(VTRUNK_NODE, &ournode_end_cmd);
 	install_element(VTRUNK_NODE, &cfg_vtrunk_number_endp_cmd);
@@ -897,7 +895,6 @@
 
 	install_element(MGCP_NODE, &cfg_mgcp_trunk_cmd);
 	install_node(&trunk_node, config_write_trunk);
-	install_default(TRUNK_NODE);
 	install_element(TRUNK_NODE, &ournode_exit_cmd);
 	install_element(TRUNK_NODE, &ournode_end_cmd);
 	install_element(TRUNK_NODE, &cfg_trunk_payload_number_cmd);
diff --git a/src/vty_interface.c b/src/vty_interface.c
index 3a654c0..ab90897 100644
--- a/src/vty_interface.c
+++ b/src/vty_interface.c
@@ -77,31 +77,6 @@
 	return vty->node;
 }
 
-
-DEFUN(node_exit, node_exit_cmd,
-      "exit", "Exit the current node\n")
-{
-	ss7_go_parent(vty);
-	return CMD_SUCCESS;
-}
-
-DEFUN(node_end, node_end_cmd,
-      "end", "End the current mode and change to the enable node\n")
-{
-	switch (vty->node) {
-	case VIEW_NODE:
-	case ENABLE_NODE:
-		break;
-	default:
-		vty_config_unlock(vty);
-		vty->node = ENABLE_NODE;
-		vty->index = NULL;
-		vty->index_sub = NULL;
-		break;
-	}
-	return CMD_SUCCESS;
-}
-
 static struct vty_app_info vty_info = {
 	.name 		= "OsmoSTP",
 	.version	= VERSION,
@@ -1316,9 +1291,6 @@
 
 static void install_defaults(int node)
 {
-	install_default(node);
-	install_element(node, &node_exit_cmd);
-	install_element(node, &node_end_cmd);
 	install_element(node, &cfg_description_cmd);
 	install_element(node, &cfg_no_description_cmd);
 }

-- 
To view, visit https://gerrit.osmocom.org/4605
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: cellmgr-ng
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0fc8142756040c98c1862ddb18a77a032f2a7143
Gerrit-Change-Number: 4605
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181127/513ba89b/attachment.html>


More information about the gerrit-log mailing list