Change in osmo-hlr[master]: add database schema versioning to the HLR database

Stefan Sperling gerrit-no-reply at
Tue Nov 27 14:32:44 UTC 2018

Stefan Sperling has posted comments on this change. ( )

Change subject: add database schema versioning to the HLR database

Patch Set 4:

(1 comment)
Commit Message:
PS4, Line 14: Furthermore, introduce a new column to the subscriber table which is
> when a commit log has a paragraph starting in the bottom with "Furthermore", that's an almost certain indicator that it should be a separate patch.
> Let's add the schema and meta data first, and in a separate patch add the new subscriber column and just bump the db schema version.

This request doesn't make a lot of sense to me. If we don't change both the version number and the schema in the same commit,
there is a risk that someone will be creating databases which use schema version 1 but are otherwise identical to the old schema.

How could the upgrade path work reliably in this situation?

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8aeaa9a404b622657cbc7138106f38aa6ad8d01b
Gerrit-Change-Number: 11898
Gerrit-PatchSet: 4
Gerrit-Owner: Stefan Sperling <ssperling at>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at>
Gerrit-Reviewer: Stefan Sperling <ssperling at>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at>
Gerrit-Comment-Date: Tue, 27 Nov 2018 14:32:44 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list