Change in osmo-hlr[master]: add database schema versioning to the HLR database
gerrit-no-reply at lists.osmocom.org
Tue Nov 27 14:32:44 UTC 2018
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11898 )
Change subject: add database schema versioning to the HLR database
Patch Set 4:
PS4, Line 14: Furthermore, introduce a new column to the subscriber table which is
> when a commit log has a paragraph starting in the bottom with "Furthermore", that's an almost certain indicator that it should be a separate patch.
> Let's add the schema and meta data first, and in a separate patch add the new subscriber column and just bump the db schema version.
This request doesn't make a lot of sense to me. If we don't change both the version number and the schema in the same commit,
there is a risk that someone will be creating databases which use schema version 1 but are otherwise identical to the old schema.
How could the upgrade path work reliably in this situation?
To view, visit https://gerrit.osmocom.org/11898
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Tue, 27 Nov 2018 14:32:44 +0000
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the gerrit-log