Change in python/osmo-python-tests[master]: ctrl: add function to skip TRAP messages

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Tue Nov 27 12:10:53 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11929 )

Change subject: ctrl: add function to skip TRAP messages
......................................................................


Patch Set 3:

> > if you'd receive an IPA message with len(payload) == 0 followed
 > by an IPA message containing a CTRL message
 > 
 > Could you provide an example - how this can be generated?

Can you provide an example on how each an every check we do in osmocom code when receiving data over a socket can be generated? Shall we ask this kind of question every time we want to secure an app misbehaving due to receiving non-expected information?

This check comes for free and actually simplifies the function in number of lines.


-- 
To view, visit https://gerrit.osmocom.org/11929
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51ce207c19a1ca96c3e2af7d5efd64f79b02fbb4
Gerrit-Change-Number: 11929
Gerrit-PatchSet: 3
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Comment-Date: Tue, 27 Nov 2018 12:10:53 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181127/1a842957/attachment.html>


More information about the gerrit-log mailing list