Change in osmo-msc[master]: libmsc/gsm_04_11.c: don't pass msgb to gsm411_rx_rp_{ack|error}

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11914 )

Change subject: libmsc/gsm_04_11.c: don't pass msgb to gsm411_rx_rp_{ack|error}
......................................................................

libmsc/gsm_04_11.c: don't pass msgb to gsm411_rx_rp_{ack|error}

Passing a message buffer containing the whole encoded message, and
a pointer to the RP header (struct gsm411_rp_hdr) is redundant.

Change-Id: I0eb5c7c485ab7d109966431bd875fa74e00936d7
---
M src/libmsc/gsm_04_11.c
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, approved



diff --git a/src/libmsc/gsm_04_11.c b/src/libmsc/gsm_04_11.c
index 52edcd6..4d43b57 100644
--- a/src/libmsc/gsm_04_11.c
+++ b/src/libmsc/gsm_04_11.c
@@ -700,7 +700,7 @@
 }
 
 /* Receive a 04.11 RP-ACK message (response to RP-DATA from us) */
-static int gsm411_rx_rp_ack(struct msgb *msg, struct gsm_trans *trans,
+static int gsm411_rx_rp_ack(struct gsm_trans *trans,
 			    struct gsm411_rp_hdr *rph)
 {
 	struct gsm_sms *sms = trans->sms.sms;
@@ -729,7 +729,7 @@
 	return 0;
 }
 
-static int gsm411_rx_rp_error(struct msgb *msg, struct gsm_trans *trans,
+static int gsm411_rx_rp_error(struct gsm_trans *trans,
 			      struct gsm411_rp_hdr *rph)
 {
 	struct gsm_network *net = trans->conn->network;
@@ -824,11 +824,11 @@
 	switch (msg_type) {
 	case GSM411_MT_RP_ACK_MO:
 		DEBUGP(DLSMS, "RX SMS RP-ACK (MO)\n");
-		rc = gsm411_rx_rp_ack(msg, trans, rp_data);
+		rc = gsm411_rx_rp_ack(trans, rp_data);
 		break;
 	case GSM411_MT_RP_ERROR_MO:
 		DEBUGP(DLSMS, "RX SMS RP-ERROR (MO)\n");
-		rc = gsm411_rx_rp_error(msg, trans, rp_data);
+		rc = gsm411_rx_rp_error(trans, rp_data);
 		break;
 	default:
 		LOGP(DLSMS, LOGL_NOTICE, "Invalid RP type 0x%02x\n", msg_type);

-- 
To view, visit https://gerrit.osmocom.org/11914
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0eb5c7c485ab7d109966431bd875fa74e00936d7
Gerrit-Change-Number: 11914
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181127/8e778078/attachment.htm>