Change in osmo-ttcn3-hacks[master]: MSC_Test: Test what happens when Paging for SMS is unanswered

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Nov 27 01:13:06 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11897 )

Change subject: MSC_Test: Test what happens when Paging for SMS is unanswered
......................................................................


Patch Set 4: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/#/c/11897/4/msc/MSC_Tests.ttcn
File msc/MSC_Tests.ttcn:

https://gerrit.osmocom.org/#/c/11897/4/msc/MSC_Tests.ttcn@1984
PS4, Line 1984: 	/* Expect the MSC to page exactly 10 times before giving up */
so ... if you're not sending an SMS above, how do you expect paging to happen?


https://gerrit.osmocom.org/#/c/11897/4/msc/MSC_Tests.ttcn@1986
PS4, Line 1986: 		[] BSSAP.receive(tr_BSSMAP_Paging(g_pars.imsi))
if above LU ended up negotiating a TMSI, I actually expect Paging by TMSI?


https://gerrit.osmocom.org/#/c/11897/4/msc/MSC_Tests.ttcn@2028
PS4, Line 2028: 	f_vty_sms_send(hex2str(pars.imsi), "2342", "Hello SMS");
ah. then drop the FIXME above?



-- 
To view, visit https://gerrit.osmocom.org/11897
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id645729551672026c6a96bb849ecd04f20cd0c56
Gerrit-Change-Number: 11897
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Tue, 27 Nov 2018 01:13:06 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181127/18da86eb/attachment.html>


More information about the gerrit-log mailing list