This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11932 ) Change subject: bts-trx: (n)ack PDCH DEACT only after TRX answered SETSLOT ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/11932/1/src/osmo-bts-trx/trx_if.c File src/osmo-bts-trx/trx_if.c: https://gerrit.osmocom.org/#/c/11932/1/src/osmo-bts-trx/trx_if.c@199 PS1, Line 199: trx_ctrl_cmd > that makes no sense since here the cb is per message and the trx_ctrl_msg is created inside the func […] Another approach: this symbol becomes trx_ctrl_cmd_cb(), and trx_ctrl_cmd() becomes a wrapper that calls trx_ctrl_cmd_cb() with NULL. How about that? :) https://gerrit.osmocom.org/#/c/11932/1/src/osmo-bts-trx/trx_if.c@259 PS1, Line 259: NULL > I foresee expanding cb use in the future, so it makes sense to keep it like this. Ok, but I am still unsure this makes sense for all commands. -- To view, visit https://gerrit.osmocom.org/11932 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I888de761b65c3ea8bfe623fcf009f3b2b57c926c Gerrit-Change-Number: 11932 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Comment-Date: Mon, 26 Nov 2018 21:09:34 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181126/5ca4254b/attachment.htm>