Change in python/osmo-python-tests[master]: ctrl: add function to skip TRAP messages

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Mon Nov 26 18:38:59 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11929 )

Change subject: ctrl: add function to skip TRAP messages
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/11929/2/osmopy/osmo_ipa.py
File osmopy/osmo_ipa.py:

https://gerrit.osmocom.org/#/c/11929/2/osmopy/osmo_ipa.py@126
PS2, Line 126:         if (int(length) != 0):
> > What if you have an empty IPA header […]
Sorry I meant an empty IPA payload. So an IPA header with payload=0, which I guess is actually valid.


https://gerrit.osmocom.org/#/c/11929/2/osmopy/osmo_ipa.py@128
PS2, Line 128:                 return self.skip_traps(tail)
> > you need the code I commented above as a base case […]
Line 121. It is the base case of your recursion so it's actually needed :)



-- 
To view, visit https://gerrit.osmocom.org/11929
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51ce207c19a1ca96c3e2af7d5efd64f79b02fbb4
Gerrit-Change-Number: 11929
Gerrit-PatchSet: 2
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Comment-Date: Mon, 26 Nov 2018 18:38:59 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181126/cc1a2933/attachment.html>


More information about the gerrit-log mailing list