Change in python/osmo-python-tests[master]: ctrl: cosmetic cleanup

daniel gerrit-no-reply at lists.osmocom.org
Mon Nov 26 15:24:02 UTC 2018


daniel has posted comments on this change. ( https://gerrit.osmocom.org/11930 )

Change subject: ctrl: cosmetic cleanup
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/11930/1/scripts/osmo_ctrl.py
File scripts/osmo_ctrl.py:

https://gerrit.osmocom.org/#/c/11930/1/scripts/osmo_ctrl.py@55
PS1, Line 55:         _leftovers(sock, socket.MSG_DONTWAIT)
sock != sck
Why did this pass jenkins builder?


https://gerrit.osmocom.org/#/c/11930/1/scripts/osmo_ctrl.py@115
PS1, Line 115:                 _leftovers(sock, socket.MSG_DONTWAIT)
Now you call it here and in set_var. We could just call it from do_set_get since that is called by set_var as well



-- 
To view, visit https://gerrit.osmocom.org/11930
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c1bf59775f08f6252d731de653ee9cc212b31da
Gerrit-Change-Number: 11930
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Comment-Date: Mon, 26 Nov 2018 15:24:02 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181126/4708828c/attachment.html>


More information about the gerrit-log mailing list