Change in python/osmo-python-tests[master]: ctrl2cgi: explicitly ignore arguments to lambda function

Max gerrit-no-reply at lists.osmocom.org
Mon Nov 26 14:18:49 UTC 2018


Max has posted comments on this change. ( https://gerrit.osmocom.org/11934 )

Change subject: ctrl2cgi: explicitly ignore arguments to lambda function
......................................................................


Patch Set 2:

(1 comment)

python tends to defer errors to the very last moment so usually just looking up is not enough :)

https://gerrit.osmocom.org/#/c/11934/2/scripts/ctrl2cgi.py
File scripts/ctrl2cgi.py:

https://gerrit.osmocom.org/#/c/11934/2/scripts/ctrl2cgi.py@111
PS2, Line 111:         method = getattr(self, 'handle_' + t_type.replace('-', ''), lambda *_: "Unhandled %s trap" % t_type)
> lol no idea if that works, I guess you looked it up somehwere.
I've tested it :)



-- 
To view, visit https://gerrit.osmocom.org/11934
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44035323b70f04eb8f5dc12123cb708f53eba188
Gerrit-Change-Number: 11934
Gerrit-PatchSet: 2
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Comment-Date: Mon, 26 Nov 2018 14:18:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181126/b3572646/attachment.html>


More information about the gerrit-log mailing list