Change in libosmocore[master]: ctrl: handle ECONNRESET on initial read gracefully

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Mon Nov 26 13:21:10 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11912 )

Change subject: ctrl: handle ECONNRESET on initial read gracefully
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/#/c/11912/4/src/gsm/ipa.c
File src/gsm/ipa.c:

https://gerrit.osmocom.org/#/c/11912/4/src/gsm/ipa.c@566
PS4, Line 566: 	if (errno == ECONNRESET && msg->l2h == NULL) {
I still really don't understand why do we want to return 0 in this case and not ECONNRESET. What's wrong wit it? if we receive ECCONNRESET it means we sent some data and the peer host answered with a RST because no socket is bound there, so there's no use in keeping the connection alive. It's an error and conn should be cleared. I don't understand what you mean in your commit with "carry on".

In any case, I still think there's no sense in having this code here instead of having it where only makes sense, that is under the if condition in line 613



-- 
To view, visit https://gerrit.osmocom.org/11912
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cbdb3909660d605181d6923031336d296ea4340
Gerrit-Change-Number: 11912
Gerrit-PatchSet: 4
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 26 Nov 2018 13:21:10 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181126/d38993d9/attachment.html>


More information about the gerrit-log mailing list