Change in libosmocore[master]: ctrl: use #define for TRAP id

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Mon Nov 26 11:37:14 UTC 2018


Max has posted comments on this change. ( https://gerrit.osmocom.org/11926 )

Change subject: ctrl: use #define for TRAP id
......................................................................


Patch Set 1:

(1 comment)

I think such questions better be addressed to ML where they could reach wider audience.

https://gerrit.osmocom.org/#/c/11926/1/src/ctrl/control_if.c
File src/ctrl/control_if.c:

https://gerrit.osmocom.org/#/c/11926/1/src/ctrl/control_if.c@159
PS1, Line 159: 	cmd->id = CTRL_CMD_TRAP_ID; /* It's a TRAP! */
> Why do we use ID=0? why not incrementing it so one can infer order of traps?
I don't know what was the reasoning behind this decision. And changing the protocol semantics is certainly outside of the scope of this patch.



-- 
To view, visit https://gerrit.osmocom.org/11926
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I33d7d4c6a1885a75a85d6f2f017430e0860b4126
Gerrit-Change-Number: 11926
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 26 Nov 2018 11:37:14 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181126/b31bc306/attachment.htm>


More information about the gerrit-log mailing list