Change in python/osmo-python-tests[master]: ctrl: cosmetic cleanup

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Mon Nov 26 11:19:37 UTC 2018


Max has uploaded this change for review. ( https://gerrit.osmocom.org/11930


Change subject: ctrl: cosmetic cleanup
......................................................................

ctrl: cosmetic cleanup

* remove unused function
* move internal function call outside of main

Change-Id: I3c1bf59775f08f6252d731de653ee9cc212b31da
---
M scripts/osmo_ctrl.py
1 file changed, 1 insertion(+), 5 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/python/osmo-python-tests refs/changes/30/11930/1

diff --git a/scripts/osmo_ctrl.py b/scripts/osmo_ctrl.py
index 771611d..2ed334d 100755
--- a/scripts/osmo_ctrl.py
+++ b/scripts/osmo_ctrl.py
@@ -52,13 +52,10 @@
         return (Ctrl().rem_header(head),) + Ctrl().verify(head, r, var, value)
 
 def set_var(sck, var, val):
+        _leftovers(sock, socket.MSG_DONTWAIT)
         (a, _, _) = do_set_get(sck, var, val)
         return a
 
-def get_var(sck, var):
-        (_, _, v) = do_set_get(sck, var)
-        return v
-
 def _leftovers(sck, fl):
         """
         Read outstanding data if any according to flags
@@ -110,7 +107,6 @@
         if options.cmd_set:
                 if len(args) < 2:
                         parser.error("Set requires var and value arguments")
-                _leftovers(sock, socket.MSG_DONTWAIT)
                 print("Got message:", set_var(sock, args[0], ' '.join(args[1:])))
 
         if options.cmd_get:

-- 
To view, visit https://gerrit.osmocom.org/11930
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3c1bf59775f08f6252d731de653ee9cc212b31da
Gerrit-Change-Number: 11930
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181126/4f5f10d8/attachment.htm>


More information about the gerrit-log mailing list