Change in libosmocore[master]: IPA: move duplicated error handling into function

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Mon Nov 26 10:46:35 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11911 )

Change subject: IPA: move duplicated error handling into function
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/11911/3/src/gsm/ipa.c
File src/gsm/ipa.c:

https://gerrit.osmocom.org/#/c/11911/3/src/gsm/ipa.c@545
PS3, Line 545:  * \param[out] ret result of recv() will be stored in here.
You are still not mentioning here that ret also contains errno if ret >0. Othwerise it would be range [-1,N] (result of recv).



-- 
To view, visit https://gerrit.osmocom.org/11911
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0147bffaf04b0baf97e5cca22948bd0e116668f
Gerrit-Change-Number: 11911
Gerrit-PatchSet: 3
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 26 Nov 2018 10:46:35 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181126/11d9a602/attachment.html>


More information about the gerrit-log mailing list