Change in osmo-sgsn[master]: gbproxy: Fix abort during APN patch

daniel gerrit-no-reply at lists.osmocom.org
Mon Nov 26 10:38:58 UTC 2018


daniel has posted comments on this change. ( https://gerrit.osmocom.org/11889 )

Change subject: gbproxy: Fix abort during APN patch
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/11889/1/src/gprs/gb_proxy.c
File src/gprs/gb_proxy.c:

https://gerrit.osmocom.org/#/c/11889/1/src/gprs/gb_proxy.c@365
PS1, Line 365: 				       msgb_bvci(msg), link_info->sgsn_nsei);
Do we need to use msg here or could we use msg_bvci(stored_msg)?


https://gerrit.osmocom.org/#/c/11889/1/src/gprs/gb_proxy.c@371
PS1, Line 371: 			     msgb_nsei(msg),
Same here, should we use link_info->sgsn_nsei just to be clear?



-- 
To view, visit https://gerrit.osmocom.org/11889
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7226fc5bcfbf58c349431d0a39cdb904fefd9e9c
Gerrit-Change-Number: 11889
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: daniel <dwillmann at sysmocom.de>
Gerrit-Comment-Date: Mon, 26 Nov 2018 10:38:58 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181126/902bcb08/attachment.html>


More information about the gerrit-log mailing list