Change in python/osmo-python-tests[master]: osmo_ctrl.py: properly ignore out-of-order traps

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Sun Nov 25 22:40:47 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11909 )

Change subject: osmo_ctrl.py: properly ignore out-of-order traps
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/#/c/11909/1/scripts/osmo_ctrl.py
File scripts/osmo_ctrl.py:

https://gerrit.osmocom.org/#/c/11909/1/scripts/osmo_ctrl.py@43
PS1, Line 43:         tail = sck.recv(4096)
what about setting tail = [] here, and then moving following snippet at the start of while loop:
if len(tail) == 0:
 sck.recv()


https://gerrit.osmocom.org/#/c/11909/1/scripts/osmo_ctrl.py@49
PS1, Line 49:                 if int(i) != 0:
what does this mean? Does 0 mean TRAP? can we have some variable enumerating those please?


https://gerrit.osmocom.org/#/c/11909/1/scripts/osmo_ctrl.py@51
PS1, Line 51:                 if len(tail) == 0:
These 2 line scan then be dropped.



-- 
To view, visit https://gerrit.osmocom.org/11909
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6de02c2f13a56f0381c97a9ab02c6c7a31cc32f
Gerrit-Change-Number: 11909
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Sun, 25 Nov 2018 22:40:47 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181125/afb8c3af/attachment.html>


More information about the gerrit-log mailing list