Change in libosmocore[master]: IPA: move duplicated error handling into inline function

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Sun Nov 25 21:50:48 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11911 )

Change subject: IPA: move duplicated error handling into inline function
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/11911/1/src/gsm/ipa.c
File src/gsm/ipa.c:

https://gerrit.osmocom.org/#/c/11911/1/src/gsm/ipa.c@545
PS1, Line 545:  * \param[out] ret result of recv() will be stored in here.
What about errno? not mentioned here.


https://gerrit.osmocom.org/#/c/11911/1/src/gsm/ipa.c@551
PS1, Line 551: static inline bool recv_discard_msg(int *ret, int fd, struct msgb *msg, int needed)
IMHO it makes more sense to return ret and have a bool *discard as out param, but fine anyway.

BTW, no need to use inline here, let the compiler decide.



-- 
To view, visit https://gerrit.osmocom.org/11911
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0147bffaf04b0baf97e5cca22948bd0e116668f
Gerrit-Change-Number: 11911
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Sun, 25 Nov 2018 21:50:48 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181125/8ec3d360/attachment.html>


More information about the gerrit-log mailing list