Change in osmo-bts[master]: rsl: Avoid sending ipa PDCH DEACT NACK followed by ACK

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Fri Nov 23 16:02:38 UTC 2018


Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11904


Change subject: rsl: Avoid sending ipa PDCH DEACT NACK followed by ACK
......................................................................

rsl: Avoid sending ipa PDCH DEACT NACK followed by ACK

It was spotted during osmo-gsm-tester test
dynts:trx-sysmocell5000+mod-bts0-dynts67-ipa+cfg-codec-fr-any that
osmo-bts-trx was answering to PDCH DEACT from BSC first with a NACK
followed immediatelly after by an ACK. That happens after the test does
a GPRS pdp ctx act successfuly and then deactivates the ctx and the 2 MS
try to place a call between them (and thus channels need to be moved to
TCH/F).

Most probably the if condition where the lines for this commit are
modified need to be fine-grained. Patch before this one should help to
understand the steates/situation in this scenario, and then a follow-up
patch can be created to improve the logic.

Change-Id: I91c65da6b6b7094f32187d3b083153a87c3219fd
---
M src/common/rsl.c
1 file changed, 1 insertion(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/04/11904/1

diff --git a/src/common/rsl.c b/src/common/rsl.c
index d4bd2f0..b4cea2c 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -2200,11 +2200,10 @@
 	}
 
 	if (lchan->state != LCHAN_S_NONE) {
-		LOGP(DRSL, LOGL_ERROR,
+		LOGP(DRSL, LOGL_NOTICE,
 		     "%s Request to PDCH %s, but lchan is still in state %s\n",
 		     gsm_ts_and_pchan_name(ts), pdch_act? "ACT" : "DEACT",
 		     gsm_lchans_name(lchan->state));
-		rsl_tx_dyn_pdch_nack(lchan, pdch_act, RSL_ERR_NORMAL_UNSPEC);
 	}
 
 	ts->flags |= pdch_act? TS_F_PDCH_ACT_PENDING

-- 
To view, visit https://gerrit.osmocom.org/11904
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I91c65da6b6b7094f32187d3b083153a87c3219fd
Gerrit-Change-Number: 11904
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181123/c5482249/attachment.html>


More information about the gerrit-log mailing list