Change in osmo-hlr[master]: add database schema versioning to the HLR database

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Fri Nov 23 15:46:50 UTC 2018


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11898 )

Change subject: add database schema versioning to the HLR database
......................................................................


Patch Set 4: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/#/c/11898/4/src/db.h
File src/db.h:

https://gerrit.osmocom.org/#/c/11898/4/src/db.h@9
PS4, Line 9: DB_STMT_SEL_SCHEMA_VERSION
Wouldn't adding this *to the beginning* shift all other
definitions and break backwards compatibility?


https://gerrit.osmocom.org/#/c/11898/4/src/db.c
File src/db.c:

https://gerrit.osmocom.org/#/c/11898/4/src/db.c@55
PS4, Line 55: DB_STMT_SEL_SCHEMA_VERSION
Ah, oh, if the value isn't stored in the DB, it wouldn't break.


https://gerrit.osmocom.org/#/c/11898/4/src/db.c@83
PS4, Line 83: DB_STMT_UPD_LAST_LU_SEEN
I don't think this is related to "database schema
versioning"... Maybe, in a separate change?



-- 
To view, visit https://gerrit.osmocom.org/11898
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8aeaa9a404b622657cbc7138106f38aa6ad8d01b
Gerrit-Change-Number: 11898
Gerrit-PatchSet: 4
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 23 Nov 2018 15:46:50 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181123/87847fd0/attachment.html>


More information about the gerrit-log mailing list