Change in libsmpp34[master]: fix use of partly initialized struct in tcp test

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Nov 23 15:38:39 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11854 )

Change subject: fix use of partly initialized struct in tcp test
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/11854/1/test_apps/tcp.c
File test_apps/tcp.c:

https://gerrit.osmocom.org/#/c/11854/1/test_apps/tcp.c@72
PS1, Line 72:         memset(&name, 0, sizeof(name));
(personally I like 'name = (struct sockaddr_in){};' -- whatever)



-- 
To view, visit https://gerrit.osmocom.org/11854
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libsmpp34
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6e488308a72be96cca6aa661f088d2c3c67a6a3
Gerrit-Change-Number: 11854
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 23 Nov 2018 15:38:39 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181123/e13359fa/attachment.html>


More information about the gerrit-log mailing list