Change in osmo-bsc[master]: handover_fsm: send HANDOVER PERFORMED msg on internal ho

dexter gerrit-no-reply at lists.osmocom.org
Fri Nov 23 11:40:58 UTC 2018


dexter has posted comments on this change. ( https://gerrit.osmocom.org/11734 )

Change subject: handover_fsm: send HANDOVER PERFORMED msg on internal ho
......................................................................


Patch Set 3:

(3 comments)

> build fails with:
 > ====
 > handover_fsm.c: In function 'send_handover_performed':
 > handover_fsm.c:678:36: error: storage size of 'ho_perf_params'
 > isn't known
 > struct gsm0808_handover_performed ho_perf_params;
 > ^
 > handover_fsm.c:718:2: error: implicit declaration of function
 > 'gsm0808_create_handover_performed' [-Werror=implicit-function-declaration]
 > msg = gsm0808_create_handover_performed(&ho_perf_params);
 > ^
 > handover_fsm.c:678:36: error: unused variable 'ho_perf_params'
 > [-Werror=unused-variable]
 > struct gsm0808_handover_performed ho_perf_params;
 > ^
 > cc1: all warnings being treated as errors
 > ====
 > 
 > otherwise the patch looks good to me

I think this is just because the related libosmocore patch is not merged. It should build after #11728 is merged.

https://gerrit.osmocom.org/#/c/11734/1/src/osmo-bsc/handover_fsm.c
File src/osmo-bsc/handover_fsm.c:

https://gerrit.osmocom.org/#/c/11734/1/src/osmo-bsc/handover_fsm.c@791
PS1, Line 791: 	if (result == HO_RESULT_OK && (ho->scope & HO_INTRA_CELL || ho->scope & HO_INTRA_BSC))
> && (ho->scope & (HO_INTRA_CELL | HO_INTRA_BSC)) […]
Done


https://gerrit.osmocom.org/#/c/11734/1/src/osmo-bsc/handover_fsm.c@792
PS1, Line 792: 		send_handover_performed(conn);
> as I commented in https://gerrit.osmocom. […]
Done


https://gerrit.osmocom.org/#/c/11734/1/src/osmo-bsc/handover_fsm.c@792
PS1, Line 792: 		send_handover_performed(conn);
> should we *always* send a handover performed, or only when the codec changed? IIUC the MSC need not  […]
See 3GPP TS 48.008, 3.2.1.25. There it reads "This message is sent from the BSS to the MSC in order to indicate that the BSS has performed an internal handover." So I think yes, it is sent always. The message contains the cell id as mandatory element, so maybe this is also related to location based services.



-- 
To view, visit https://gerrit.osmocom.org/11734
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If26e5807280e0f75a423b3b04f8e3c698c82a351
Gerrit-Change-Number: 11734
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Nov 2018 11:40:58 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181123/91a022af/attachment.html>


More information about the gerrit-log mailing list