Change in osmo-hlr[master]: add database schema versioning to the HLR database

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Nov 22 18:34:39 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11898 )

Change subject: add database schema versioning to the HLR database
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/#/c/11898/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11898/1//COMMIT_MSG@17
PS1, Line 17: 
Maybe specify that this functionality will be implemented in forthcoming patches.


https://gerrit.osmocom.org/#/c/11898/1/sql/hlr.sql
File sql/hlr.sql:

https://gerrit.osmocom.org/#/c/11898/1/sql/hlr.sql@48
PS1, Line 48: 	-- last_lu_seen TIMESTAMP default NULL
I'm fine with possibility to update on the fly, but why requiring everybody who uses this .sql file to go through the entire process? Just provide here the field and one INSERT to the meta table with version=1.


https://gerrit.osmocom.org/#/c/11898/1/src/db.c
File src/db.c:

https://gerrit.osmocom.org/#/c/11898/1/src/db.c@251
PS1, Line 251: 	} else {
Would probably make sense to check which specific error is returned if the table doesn't exist, and apply this schema_version=0, and return an error for other errors.



-- 
To view, visit https://gerrit.osmocom.org/11898
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8aeaa9a404b622657cbc7138106f38aa6ad8d01b
Gerrit-Change-Number: 11898
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 22 Nov 2018 18:34:39 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181122/08c1233e/attachment.html>


More information about the gerrit-log mailing list