Change in python/osmo-python-tests[master]: ctrl2cgi.py: log address on errors

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Thu Nov 22 18:02:07 UTC 2018


Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11896 )

Change subject: ctrl2cgi.py: log address on errors
......................................................................

ctrl2cgi.py: log address on errors

Change-Id: I80cdcda134766c679c2b80b848fb9db853321cfd
Related: SYS#4399
---
M scripts/ctrl2cgi.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, approved



diff --git a/scripts/ctrl2cgi.py b/scripts/ctrl2cgi.py
index 6be36c4..1b5e952 100755
--- a/scripts/ctrl2cgi.py
+++ b/scripts/ctrl2cgi.py
@@ -141,7 +141,7 @@
         params['h'] = gen_hash(params, self.factory.secret_key)
         d = post(self.factory.location, None, params=params)
         d.addCallback(partial(handle_reply, self.transport.write, self.factory.log)) # treq's collect helper is handy to get all reply content at once using closure on ctx
-        d.addErrback(lambda e, bsc: self.factory.log.critical("HTTP POST error %s while trying to register BSC %s" % (e, bsc)), bsc) # handle HTTP errors
+        d.addErrback(lambda e, bsc: self.factory.log.critical("HTTP POST error %s while trying to register BSC %s on %s" % (e, bsc, self.factory.location)), bsc) # handle HTTP errors
         # Ensure that we run only limited number of requests in parallel:
         yield self.factory.semaphore.acquire()
         yield d # we end up here only if semaphore is available which means it's ok to fire the request without exceeding the limit

-- 
To view, visit https://gerrit.osmocom.org/11896
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I80cdcda134766c679c2b80b848fb9db853321cfd
Gerrit-Change-Number: 11896
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181122/0a24a7f2/attachment.htm>


More information about the gerrit-log mailing list