This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11894 ) Change subject: gbproxy: fix formatting in gbproxy-state command ...................................................................... gbproxy: fix formatting in gbproxy-state command In ctrl protocol we don't need any explicit formatting as it might interfere with client processing our response. Let's drop trailing '\n'. Change-Id: I3f32e01dd50a53991c292aeee57a78d81cdc5429 Related: SYS#2655 --- M src/gprs/gb_proxy_ctrl.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified Harald Welte: Looks good to me, approved diff --git a/src/gprs/gb_proxy_ctrl.c b/src/gprs/gb_proxy_ctrl.c index 032d8d4..694a2f7 100644 --- a/src/gprs/gb_proxy_ctrl.c +++ b/src/gprs/gb_proxy_ctrl.c @@ -64,7 +64,7 @@ struct gprs_ra_id raid; gsm48_parse_ra(&raid, peer->ra); - cmd->reply = talloc_asprintf_append(cmd->reply, "%u,%u,%u,%u,%u,%u,%s\n", + cmd->reply = talloc_asprintf_append(cmd->reply, "%u,%u,%u,%u,%u,%u,%s", peer->nsei, peer->bvci, raid.mcc, raid.mnc, raid.lac, raid.rac, -- To view, visit https://gerrit.osmocom.org/11894 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3f32e01dd50a53991c292aeee57a78d81cdc5429 Gerrit-Change-Number: 11894 Gerrit-PatchSet: 1 Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181122/bba5ca26/attachment.htm>